-
Notifications
You must be signed in to change notification settings - Fork 6.8k
updating License for dlpack for v1.8 release #19433
Conversation
Hey @access2rohit , Thanks for submitting the PR
CI supported jobs: [clang, windows-cpu, windows-gpu, centos-cpu, unix-cpu, centos-gpu, edge, miscellaneous, website, unix-gpu, sanity] Note: |
@samskalicky @leezu Can you review ? |
Thank you. |
There is no need to update the copyright notice. TVM doesn't include copyright notice (https://github.com/apache/incubator-tvm/blob/39cd612cdbf9a2443b5561b90b4b4a55996274f1/LICENSE#L203-L240) and it's not mentioned in the https://infra.apache.org/licensing-howto.html |
Its not for TVM it is for dlpack which is MXNet's direct dependecy. I made this PR to be consistent with what already exists in the MXNet's LICENSE file |
It's great to be consistent with the existing MXNet License file but my point is that such consistent inclusion will be very hard to keep updated at every release and isn't needed according to the ASF licensing howto and TVM's practice: The howto states "In LICENSE, add a pointer to the dependency's license within the distribution and a short note summarizing its licensing" and does not require the inclusion of copyright statements. |
This change is already included in #19440, you can close this PR. Thanks @access2rohit |
Description
update
dlpack
's LICENSE #19427Checklist
Essentials